tor-browser-bundle-bin: add comment explaining allowSubstitutes=false #192205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The comments added by this commit are my summary of @joachifm's (very patient) explanation of the reason for hydraPlatforms=[] (bandwidth) and allowSubstitutes=false; (don't bother checking because it isn't on cache.nixos.org anyways).
ghost
referenced
this pull request
Sep 21, 2022
To better support users that are unable to access the official Tor distribution site, e.g., #26184
|
More details here: https://discourse.nixos.org/t/why-is-caching-for-tor-browser-bundle-bin-disabled/16499/2 and in the commit message for ecd0e1a I'll revisit this in the morning and either add more information or close it. |
ghost
marked this pull request as draft
|
The source is only a small 108M and the final build 251M which should not make any difference for hydra or the CDN. Also this is a recuring problem, so I firmly believe we try to save bandwidth at the wrong point here. Closing and removing that from meta in my PR. |
pkgs/applications/networking/browsers/tor-browser-bundle-bin/default.nix
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closed by #192220
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notesThe comments added by this commit are my summary of @joachifm's (very patient)
explanation of the reason for hydraPlatforms=[] (bandwidth) and
allowSubstitutes=false; (don't bother checking because it isn't on
cache.nixos.org anyways).